Prevent duplicate sub-interval data labels #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
force-pushed
the
no-repeats-in-data-label
branch
from
db6f2db to
72927e3
Compare
|
It looks like lighkurve is calling functions in oktopus, which depends on autograd, which is no longer maintained. This was causing a test failure. |
bmorris3
force-pushed
the
no-repeats-in-data-label
branch
from
fa33ad6 to
09c9d24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 93.92% 91.33% -2.60%
==========================================
Files 37 41 +4
Lines 1598 2055 +457
==========================================
+ Hits 1501 1877 +376
- Misses 97 178 +81 ☔ View full report in Codecov by Sentry. |
|
The other option would be to just not append at all if manually passing a data label - can you think of a case where providing a data label would still want the quarter/whatever automatically appended? |
kecnry
reviewed
Jul 15, 2024
| @@ -24,6 +24,7 @@ dependencies = [ | |||
| # to devdeps in tox.ini | |||
| "jdaviz>=3.10.2,<3.11", | |||
| "lightkurve>=2.4.1", | |||
| "numpy<2", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you load Kepler data from Quarter 10 with a
data_label = "Target in Q10", the parser will happily add another "Q10" to the end of the data label 🐱. This PR checks if the sub-interval for any mission is already in the data label, and only adds one if none is found.